ARCO-156: fix row close

bitcoin-sv · Sep 18, 2024 · 71013f1 · 71013f1
1 parent 424d7e2
commit 71013f1
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/internal/metamorph/store/postgresql/postgres.go b/internal/metamorph/store/postgresql/postgres.go
@@ -547,9 +547,9 @@ func (p *PostgreSQL) GetSeenOnNetwork(ctx context.Context, since time.Time, unti
 		}
 		return nil, err
 	}
+	defer rows.Close()
 
 	res, err := getStoreDataFromRows(rows)
-	_ = rows.Close()
 
 	if err != nil {
 		if rollBackErr := tx.Rollback(); rollBackErr != nil {
@@ -637,10 +637,9 @@ func (p *PostgreSQL) UpdateStatusBulk(ctx context.Context, updates []store.Updat
 		}
 		return nil, err
 	}
+	defer rows.Close()
 
 	res, err := getStoreDataFromRows(rows)
-	_ = rows.Close()
-
 	if err != nil {
 		if rollBackErr := tx.Rollback(); rollBackErr != nil {
 			return nil, errors.Join(err, fmt.Errorf("failed to rollback: %v", rollBackErr))
@@ -846,7 +845,6 @@ func (p *PostgreSQL) UpdateMined(ctx context.Context, txsBlocks []*blocktx_api.T
 
 	defer rows.Close()
 	res, err := getStoreDataFromRows(rows)
-
 	if err != nil {
 		if rollBackErr := tx.Rollback(); rollBackErr != nil {
 			return nil, errors.Join(err, fmt.Errorf("failed to rollback: %v", rollBackErr))