ARCO-205: fix PR comments

bitcoin-sv · Sep 30, 2024 · 7aa4925 · 7aa4925
1 parent 5236173
commit 7aa4925
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/internal/metamorph/processor.go b/internal/metamorph/processor.go
@@ -400,8 +400,6 @@ func (p *Processor) StartProcessStatusUpdatesInStorage() {
 	go func() {
 		defer p.waitGroup.Done()
 
-		//statusUpdatesMap := map[chainhash.Hash]store.UpdateStatus{}
-
 		for {
 			select {
 			case <-p.ctx.Done():
@@ -417,11 +415,6 @@ func (p *Processor) StartProcessStatusUpdatesInStorage() {
 				if len(actualUpdateStatusMap) >= p.processStatusUpdatesBatchSize {
 					p.checkAndUpdate(actualUpdateStatusMap)
 
-					err = p.cacheStore.Del(CacheStatusUpdateKey)
-					if err != nil {
-						p.logger.Error("failed to reset status update map", slog.String("err", err.Error()))
-					}
-
 					// Reset ticker to delay the next tick, ensuring the interval starts after the batch is processed.
 					// This prevents unnecessary immediate updates and maintains the intended time interval between batches.
 					ticker.Reset(p.processStatusUpdatesInterval)
@@ -431,11 +424,6 @@ func (p *Processor) StartProcessStatusUpdatesInStorage() {
 				if len(statusUpdatesMap) > 0 {
 					p.checkAndUpdate(statusUpdatesMap)
 
-					err := p.cacheStore.Del(CacheStatusUpdateKey)
-					if err != nil {
-						p.logger.Error("failed to reset status update map", slog.String("err", err.Error()))
-					}
-
 					// Reset ticker to delay the next tick, ensuring the interval starts after the batch is processed.
 					// This prevents unnecessary immediate updates and maintains the intended time interval between batches.
 					ticker.Reset(p.processStatusUpdatesInterval)
@@ -465,6 +453,11 @@ func (p *Processor) checkAndUpdate(statusUpdatesMap map[chainhash.Hash]store.Upd
 	if err != nil {
 		p.logger.Error("failed to bulk update statuses", slog.String("err", err.Error()))
 	}
+
+	err = p.cacheStore.Del(CacheStatusUpdateKey)
+	if err != nil {
+		p.logger.Error("failed to reset status update map", slog.String("err", err.Error()))
+	}
 }
 
 func (p *Processor) statusUpdateWithCallback(statusUpdates, doubleSpendUpdates []store.UpdateStatus) error {