Add metamorph records clearing #217
Conversation
nozim
commented
Dec 17, 2023
•
nozim
commented
- add background job for clearing expired transactions in metamorph tables
There was a problem hiding this comment.
If you copy these files from this path: metamorph/store/postgresql/migrations
then they should be exactly the same as they are the migration files which are actually used in the deployment. Right now they're not the same
There was a problem hiding this comment.
The migrations are still not exaclty the same. This schema is missing
There was a problem hiding this comment.
why does it have to have custom schema?
| } | ||
|
|
||
| func ClearMetamorph(params ClearRecordsParams) error { | ||
| if err := runDelete("blocks", params); err != nil { |
There was a problem hiding this comment.
After adding the schema the from clause would be metamorph.blocks like here
arc/metamorph/store/postgresql/postgres.go
Line 603 in fbe2265
There was a problem hiding this comment.
I'm not sure it's a good idea to hardcode database name inside the query. Because if the name inside db connection can be different from the one inside the query.
| if err := runDelete("blocks", params); err != nil { | ||
| return err | ||
| } | ||
| if err := runDelete("transactions", params); err != nil { |
There was a problem hiding this comment.
The same here
There was a problem hiding this comment.
same here, why do we need to hardcode the database name?
|
* Add metamorph records clearing * Add metamorph database testing utility code * Fix compilation errors * Fix typo * Amend blocktx tests * Fix compilation errors * Fix test failure * Fix compilation error * Fix formatting in blocktx db utility * Add timestamp columnes for metamorph tables * Rename migrations * Fix test errors, amend migrations * Amend schema name migrations * Amend metamorph tests --------- Co-authored-by: Nozim Mehrubonov <[email protected]>
