Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARCO-149: change callback column to allow saving multiple parameters #539

Merged
merged 8 commits into from
Aug 9, 2024
Merged

ARCO-149: change callback column to allow saving multiple parameters #539

merged 8 commits into from
Aug 9, 2024

Conversation

pawellewandowski98
Copy link
Collaborator

Description

  • changed transaction db, two columns (callback_url and callback_token) were combined into callbacks (type jsonb) which allows for saving multiple callbacks for one tx
  • Adjusted queries to new structure

@pawellewandowski98 pawellewandowski98 self-assigned this Aug 8, 2024
kuba-4chain
kuba-4chain reviewed Aug 8, 2024
View reviewed changes
internal/metamorph/callbacker.go Show resolved Hide resolved
internal/metamorph/server.go Outdated Show resolved Hide resolved
internal/metamorph/server.go Outdated Show resolved Hide resolved
internal/metamorph/store/postgresql/postgres.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 force-pushed the feature/multiple-callbacks branch from 06278af to a81927d Compare August 9, 2024 13:45
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
78.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@pawellewandowski98 pawellewandowski98 merged commit 03db169 into main Aug 9, 2024
5 of 6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feature/multiple-callbacks branch August 9, 2024 13:53
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
@pawellewandowski98
ARCO-149: change callback column to allow saving multiple parameters (#…
8e67534 
…539)

* ARCO-149: refactor callback column to allow saving multiple parameters

* ARCO-149: fix unkeyed fields

* ARCO-149: remove unnecessary comments

* ARCO-149: refactor migrations and postgres methods

* ARCO-149: remove goroutine from callback

* ARCO-149: change direct comparisions to sql not null

* ARCO-149: check callback url and token length instead of comparing to null

* ARCO-149: revert defer func changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

@kuba-4chain kuba-4chain kuba-4chain approved these changes

@boecklim boecklim boecklim approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawellewandowski98 @boecklim @kuba-4chain @arkadiuszos4chain