Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCO-187: change Cumulative Fees Validation behavior #566

Closed
wants to merge 4 commits into from

Conversation

arkadiuszos4chain
Copy link
Collaborator

@arkadiuszos4chain arkadiuszos4chain commented Aug 23, 2024

Description of Changes

  • Cumulative Fees Validation behavior changed: validation doesn't check unmined ancestors chain length anymore
  • new Strict Cumulative Fees Validation - works as CFV with ancestors chain lenght validation

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@arkadiuszos4chain arkadiuszos4chain changed the title Feat arco 187 ARCO-187: change Cumulative Fees Validation behavior Aug 23, 2024
@arkadiuszos4chain arkadiuszos4chain self-assigned this Aug 23, 2024
@arkadiuszos4chain arkadiuszos4chain marked this pull request as ready for review August 23, 2024 14:03
pkg/api/arc.yaml Outdated Show resolved Hide resolved
doc/README.md Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
45.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@boecklim
Copy link
Collaborator

boecklim commented Sep 4, 2024

Replaced by #574.
PR for feature of Strict Cumulative Fees Validation may be re-opened later if needed.

@boecklim boecklim closed this Sep 4, 2024
@arkadiuszos4chain arkadiuszos4chain deleted the feat-arco-187 branch December 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants