Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCO-198: refactor integration tests #579

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Conversation

arkadiuszos4chain
Copy link
Collaborator

@arkadiuszos4chain arkadiuszos4chain commented Sep 3, 2024

Description of Changes

  • move docker related code to test/utils
  • move common test functions to test/utils
  • decorate test helper functions with t.Helper() for better logs
  • ensure all docker resources are removed after tests even on errors

Linked Issues / Tickets

ARCO-198

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@arkadiuszos4chain arkadiuszos4chain self-assigned this Sep 3, 2024
Copy link

sonarqubecloud bot commented Sep 3, 2024

@arkadiuszos4chain arkadiuszos4chain marked this pull request as ready for review September 3, 2024 16:07
Copy link
Collaborator

@kuba-4chain kuba-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥

@arkadiuszos4chain arkadiuszos4chain merged commit 2b723dd into main Sep 4, 2024
6 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the refactor-arco-198 branch September 4, 2024 11:39
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
* move docker related code to test/utils
* move common test functions to test/utils
* decorate test helper functions with t.Helper() for better logs
* ensure all docker resources are removed after tests even on errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants