Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ARCO-194): update statuses in bulk query #586

Merged
merged 28 commits into from
Dec 18, 2024
Merged

feat(ARCO-194): update statuses in bulk query #586

merged 28 commits into from
Dec 18, 2024

Conversation

pawellewandowski98
Copy link
Collaborator

@pawellewandowski98 pawellewandowski98 commented Sep 11, 2024 •
edited
Loading

Description of Changes

Fix updating statuses in UpdateStatusBulk

  • If there was more than one status change before last update, use StatusHistory field and current status when updating status_history
  • If there is update with lower status than current one but it is not in status history add his history plus status to current status history

Linked Issues / Tickets

Fixes changes from ARCO-194

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@pawellewandowski98 pawellewandowski98 self-assigned this Sep 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pawellewandowski98 pawellewandowski98 marked this pull request as draft September 16, 2024 08:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pawellewandowski98 pawellewandowski98 force-pushed the fix/update-statuses branch 2 times, most recently from 814741f to fb84e45 Compare November 26, 2024 08:07
@pawellewandowski98 pawellewandowski98 changed the title ARCO-194: update statuses in bulk query feat(ARCO-194): update statuses in bulk query Nov 26, 2024
@pawellewandowski98 pawellewandowski98 marked this pull request as ready for review December 9, 2024 09:05
kuba-4chain
kuba-4chain reviewed Dec 11, 2024
View reviewed changes
internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved
internal/metamorph/store/postgresql/postgres.go Outdated Show resolved Hide resolved
internal/metamorph/store/postgresql/postgres.go Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pawellewandowski98 pawellewandowski98 merged commit 0ae4172 into main Dec 18, 2024
8 checks passed
@pawellewandowski98 pawellewandowski98 deleted the fix/update-statuses branch December 18, 2024 09:06
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@pawellewandowski98
feat(ARCO-194): update statuses in bulk query (#586)
564bfa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuba-4chain kuba-4chain kuba-4chain approved these changes

@boecklim boecklim boecklim approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawellewandowski98 @boecklim @kuba-4chain