-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARCO-183: implement quarantine for problematic callback receivers #587
Conversation
f34a4c7
to
f5a51df
Compare
2d449e8
to
3f6a3c1
Compare
@@ -0,0 +1,3 @@ | |||
ALTER TABLE callbacker.callbacks ADD COLUMN quarantine_until TIMESTAMPTZ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think correct english would be quarantined_until
, but not sure.
Thinking of naming I think the callback itself is not quarantined, but rather the URL.
What would you think of postponed_until
?
IMO that would be a bit more expressive name of the field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, it's a better name.
Changed
Quality Gate failedFailed conditions |
* ARCO-183: put problematic callback receivers to quarantine * ARCO-200: document changes and describe callbacker components (#588)
Description of Changes
This update introduces a quarantine mechanism for receivers that fail to handle callbacks, helping to prevent repeated failed sends.
Changes:
Testing Procedure
Checklist:
CHANGELOG.md
with my changes