Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCO-205: use cache for updating txs in metamorph #601

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

pawellewandowski98
Copy link
Collaborator

Description of Changes

Use cache in metamorph to update tx

Linked Issues / Tickets

ARCO-205

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

}

// UnmarshalJSON Custom method to unmarshall the UpdateStatus struct
func (u *UpdateStatus) UnmarshalJSON(data []byte) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This methods are automatically used by overwriting default methods which cannot marshal/unmarshal chainhash.Hash and error

Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@pawellewandowski98 pawellewandowski98 merged commit b553773 into main Oct 11, 2024
5 of 6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feature/implement-cache branch October 11, 2024 07:33
github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
* ARCO-205: use cache for updating txs in metamorph

* ARCO-105: update tests

* ARCO-205: fix serialization

* ARCO-205: update serialization

* ARCO-205: fix PR comments

* ARCO-205: change fields for marshalling to private

* ARCO-205: revert changes

* ARCO-205: remove log
kameshraj23 pushed a commit that referenced this pull request Oct 18, 2024
* ARCO-205: use cache for updating txs in metamorph

* ARCO-105: update tests

* ARCO-205: fix serialization

* ARCO-205: update serialization

* ARCO-205: fix PR comments

* ARCO-205: change fields for marshalling to private

* ARCO-205: revert changes

* ARCO-205: remove log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants