-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ARCO-115): Reorg Support #611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba-4chain
force-pushed
the
reorg-support
branch
from
November 6, 2024 13:55
0a79c26
to
7d9b147
Compare
boecklim
reviewed
Nov 11, 2024
boecklim
reviewed
Nov 11, 2024
internal/blocktx/store/postgresql/migrations/000019_add_is_longest.up.sql
Show resolved
Hide resolved
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
boecklim
reviewed
Nov 12, 2024
kuba-4chain
force-pushed
the
reorg-support
branch
2 times, most recently
from
November 22, 2024 12:46
4d49ace
to
ea33f58
Compare
boecklim
reviewed
Nov 22, 2024
boecklim
reviewed
Nov 27, 2024
kuba-4chain
force-pushed
the
reorg-support
branch
2 times, most recently
from
November 28, 2024 10:47
0dcabf9
to
2868570
Compare
boecklim
approved these changes
Nov 29, 2024
kuba-4chain
force-pushed
the
reorg-support
branch
2 times, most recently
from
December 4, 2024 17:15
413bd3e
to
680e8d5
Compare
arkadiuszos4chain
approved these changes
Dec 5, 2024
kuba-4chain
force-pushed
the
reorg-support
branch
from
December 5, 2024 10:06
f1ee716
to
bd1fb81
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
UpsertBlock
query with additional checksGetBlockGaps
was updated and simplified.MINED_IN_STALE_BLOCK
was introduced in metamorph api.MINED
- no change hereSEEN_ON_NETWORK
state (ignored) until they are found in the longest chain (which eventually should happen, because nodes put those transactions back in their mempool)MINED_IN_STALE_BLOCK
- this is to inform users that their transaction is no longer mined in the longest chain, so they have to wait until it'sMINED
againPeerTxMessage
->TxStatusMessage
GetMinedTransactionsResult
->TransactionBlock
chain
-> slice of blocksFlow diagram of the updated
processBlock
function in blocktx processorLinked Issues / Tickets
ARCO-178
ARCO-179
ARCO-199
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist:
CHANGELOG.md
with my changes