New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ARCO-283): remove freecache, combine methods with cache implementation #643

Merged

pawellewandowski98 merged 26 commits into main from refactor/cache-implementation

Dec 4, 2024

Collaborator

pawellewandowski98 commented Nov 13, 2024

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

I have added new unit tests
All tests pass locally
I have tested manually in my local environment

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have updated CHANGELOG.md with my changes

pawellewandowski98 self-assigned this

Collaborator

arkadiuszos4chain commented Nov 13, 2024

I would introduce a few changes (since we already virtualize the cache engine):

implement a simple InMemoryCacheStore
rename config.InternalCache to config.InMemory
use InMemoryCacheStore as the default in the processor. This will simplify the code by reducing the number of if statements.

Bonus question: are you sure it's good to store the entire map in the cache instead of querying and saving individual records?

arkadiuszos4chain reviewed

View reviewed changes

internal/metamorph/integration_test/double_spend_integration_test.go Outdated Show resolved Hide resolved

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

internal/metamorph/processor_test.go Outdated Show resolved Hide resolved

kuba-4chain reviewed

View reviewed changes

internal/cache/in-memory.go Outdated Show resolved Hide resolved

arkadiuszos4chain approved these changes

View reviewed changes

kuba-4chain approved these changes

View reviewed changes

boecklim reviewed

View reviewed changes

config/example_config.yaml Outdated Show resolved Hide resolved

boecklim reviewed

View reviewed changes

config/example_config.yaml Outdated Show resolved Hide resolved

boecklim reviewed

View reviewed changes

internal/cache/in_memory.go Outdated Show resolved Hide resolved

boecklim reviewed

View reviewed changes

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

boecklim reviewed

View reviewed changes

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

kuba-4chain reviewed

View reviewed changes

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

internal/cache/redis.go Outdated Show resolved Hide resolved

internal/cache/in_memory.go Outdated Show resolved Hide resolved

internal/cache/redis.go Outdated Show resolved Hide resolved

arkadiuszos4chain self-requested a review

November 19, 2024 14:13

arkadiuszos4chain reviewed

View reviewed changes

internal/cache/in_memory.go Outdated Show resolved Hide resolved

internal/cache/in_memory.go Outdated Show resolved Hide resolved

pawellewandowski98 force-pushed the refactor/cache-implementation branch from 9c54bdc to 04d066e Compare

November 20, 2024 09:57

boecklim reviewed

View reviewed changes

internal/cache/redis.go Show resolved Hide resolved

arkadiuszos4chain self-requested a review

November 20, 2024 11:14

arkadiuszos4chain requested changes

View reviewed changes

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

internal/cache/cache.go Outdated Show resolved Hide resolved

internal/metamorph/processor_helpers.go Outdated Show resolved Hide resolved

internal/metamorph/processor_helpers.go Show resolved Hide resolved

arkadiuszos4chain reviewed

View reviewed changes

internal/cache/redis.go Outdated Show resolved Hide resolved

pawellewandowski98 force-pushed the refactor/cache-implementation branch 3 times, most recently from b64abcd to 1a8ddd9 Compare

November 26, 2024 08:06

pawellewandowski98 added 8 commits

November 27, 2024 09:12


          feat(ARCO-283): remove freecache, combine methods with cache implemen…

137a106

…tation


          fix(ARCO-283): fix linter error

71ab858


          refactor(ARCO-283): use struct instead of plain map

d80f8fb


          feat(ARCO-283): clear cache after update

ccc9822


          feat(ARCO-283): add in memory cache

eb6b402


          fix(ARCO-283): fix linter errors

9a3056e


          fix(ARCO-283): fix PR comments

9c85066


          refactor(ARCO-283): use sync map in memory cache

485328c

pawellewandowski98 added 18 commits

November 27, 2024 09:12


          test(ARCO-283): fix unit tests

f49c7ab


          feat(ARCO-283): save separate transactions in cache

c3f74ba


          fix(ARCO-283): fix build and linter errors

b157306


          feat(ARCO-283): add option to store data in cache for one hash

b37d5ee


          chore(ARCO-283): remove unused code

44f425f


          chore(ARCO-283): remove log

6019cef


          feat(ARCO-283): add transaction for redis operations

6996f76


          chore(ARCO-283): check if key exists when counting records

00495df


          chore(ARCO-283): remove clear cache

73fdadc


          feat(ARCO-283): split cache methods

1988ea3


          refactor(ARCO-283): refactor in-memory cache method

b94b62c


          fix(ARCO-283): fix PR comments

15b03a7


          test(ARCO-283): add Redis integration tests

81a6db1


          fix(ARCO-283): fix linter error

3f95b2b


          test(ARCO-283): fix Redis test

f633e42


          fix(ARCO-283): update status in cache only when bigger

7158db0


          fix(ARCO-283): fix PR comments

fc19ee8


          fix(ARCO-283): fix linter error

4fcc557

pawellewandowski98 force-pushed the refactor/cache-implementation branch from 1a8ddd9 to 4fcc557 Compare

November 27, 2024 08:12

sonarqubecloud bot commented Nov 27, 2024

Quality Gate failed

Failed conditions
56.7% Coverage on New Code (required ≥ 80%)
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

boecklim approved these changes

View reviewed changes

arkadiuszos4chain self-requested a review

December 4, 2024 09:13

arkadiuszos4chain approved these changes

View reviewed changes

pawellewandowski98 merged commit 568adb2 into main

6 of 7 checks passed

pawellewandowski98 deleted the refactor/cache-implementation branch

December 4, 2024 09:15

github-actions bot pushed a commit that referenced this pull request


          feat(ARCO-283): remove freecache, combine methods with cache implemen…

68712dc

…tation (#643)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet