Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: If put transaction returns context deadline exceeded, check for status first to avoid false negatives #650

Merged
merged 2 commits into from
Nov 19, 2024
Merged

fix: If put transaction returns context deadline exceeded, check for status first to avoid false negatives #650

merged 2 commits into from
Nov 19, 2024

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Nov 19, 2024 •
edited
Loading

Description of Changes

  • If put transaction gets context deadline exceeded, check for status first to avoid false negatives
  • Add unit tests

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim changed the title fix: If put transaction gets context deadline exceeded, check for sta… fix: If put transaction returns context deadline exceeded, check for status first to avoid false negatives Nov 19, 2024
@boecklim
fix(ARCO-290): If put transaction gets context deadline exceeded, che…
737d1df 
…ck for status first to avoid false negatives
@boecklim boecklim marked this pull request as ready for review November 19, 2024 15:00
@boecklim boecklim force-pushed the fix/metamorph-client branch from 3b5a00c to 737d1df Compare November 19, 2024 15:14
arkadiuszos4chain
arkadiuszos4chain requested changes Nov 19, 2024
View reviewed changes
pkg/metamorph/client.go Outdated Show resolved Hide resolved
pkg/metamorph/client.go Outdated Show resolved Hide resolved
pkg/metamorph/client.go Outdated Show resolved Hide resolved
pkg/metamorph/client.go Outdated Show resolved Hide resolved
@boecklim boecklim force-pushed the fix/metamorph-client branch from 2e2b11f to 8d78ec6 Compare November 19, 2024 15:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@boecklim boecklim merged commit 176835c into main Nov 19, 2024
6 of 7 checks passed
@boecklim boecklim deleted the fix/metamorph-client branch November 19, 2024 16:04
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@boecklim
fix: If put transaction returns context deadline exceeded, check for …
72ea85e 
…status first to avoid false negatives (#650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklim @arkadiuszos4chain