Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix custom tx status metrics #652

Merged
merged 1 commit into from
Nov 21, 2024
Merged

refactor: Fix custom tx status metrics #652

merged 1 commit into from
Nov 21, 2024

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Nov 20, 2024

Description of Changes

  • Replace not mined metric by not final metric as rejected is also a final status
  • Exclude SEEN_IN_ORPHAN_MEMPOOL from not seen metric

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim merged commit ef304e8 into main Nov 21, 2024
7 checks passed
@boecklim boecklim deleted the fix/custom-metrics branch November 21, 2024 08:38
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants