Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ARCO-115): rebroadcast stale txs #691

Closed
wants to merge 5 commits into from

Conversation

kuba-4chain
Copy link
Collaborator

@kuba-4chain kuba-4chain commented Dec 5, 2024

Description of Changes

  • Transactions that are ONLY in the STALE chain and are not found in the longest chain, will try to be re-announced to the network and circle back from statuses SEEN_ON_NETWORK forward.
  • Removed option onlyLongestChain from GetMinedTransactions blocktx store method.
  • Respecting height range in GetChainTip blocktx store method.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@kuba-4chain kuba-4chain force-pushed the feat/rebroadcast-stale-txs branch 2 times, most recently from 25b267f to 8e328ea Compare December 5, 2024 12:30
Base automatically changed from reorg-support to main December 5, 2024 14:10
@kuba-4chain kuba-4chain force-pushed the feat/rebroadcast-stale-txs branch from 8e328ea to 73a991c Compare December 5, 2024 14:14
@kuba-4chain kuba-4chain marked this pull request as draft December 13, 2024 13:47
@kuba-4chain kuba-4chain force-pushed the feat/rebroadcast-stale-txs branch from 73a991c to 2e162a5 Compare December 23, 2024 15:53
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@kuba-4chain kuba-4chain marked this pull request as ready for review December 23, 2024 16:07
@boecklim boecklim mentioned this pull request Jan 9, 2025
7 tasks
@boecklim
Copy link
Collaborator

Closing for now as feature not a high priority

@boecklim boecklim closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants