-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multicast #728
Open
arkadiuszos4chain
wants to merge
6
commits into
feat-p2p-mtm
Choose a base branch
from
feat-multicast
base: feat-p2p-mtm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: multicast #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba-4chain
approved these changes
Dec 23, 2024
MaxAllowedBlockHeightMismatch int `mapstructure:"maxAllowedBlockHeightMismatch"` | ||
MessageQueue *MessageQueueConfig `mapstructure:"mq"` | ||
P2pReadBufferSize int `mapstructure:"p2pReadBufferSize"` | ||
BlockchainNetwork *BlockchainNetwork[*BlocktxGroups] `mapstructure:"bcnet"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unnecessarily complicated. You could just create 2 structs, such as BlocktxMcast
and MetamorphMcast
or something like that. Would be easier to use it later in code as well. But it's just my opinion :)
arkadiuszos4chain
force-pushed
the
feat-multicast
branch
from
December 30, 2024 08:50
1d78267
to
a0912f8
Compare
arkadiuszos4chain
force-pushed
the
feat-multicast
branch
from
December 30, 2024 22:00
a0912f8
to
21082c8
Compare
Quality Gate failedFailed conditions |
shotasilagadzetaal
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add Hybrid Blockchain Communication Using Multicast Groups
Key Changes
1. Hybrid Communication Mode
hybrid
, which combinesp2p
communication with a multicast group-based mechanism.classic
(current approch with p2p connection only) andhybrid
communication modes,2. Transparent Integration for Services
mediator
inmetamorph
, were implemented to handle message translation and routing betweenp2p
and multicast groups.3. New Structures and Improvements
Benefits
p2p
setups.Linked Issues / Tickets
Reference any related issues or tickets, e.g. "Closes #123".
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist:
CHANGELOG.md
with my changes