Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ARCO-320): force validation #756

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(ARCO-320): force validation #756

merged 1 commit into from
Jan 23, 2025

Conversation

shotasilagadzetaal
Copy link
Collaborator

@shotasilagadzetaal shotasilagadzetaal commented Jan 23, 2025

Description of Changes

Now if the header is set we don't check if tx is present in the db or not to skip its validation. We just go ahead and validate it regardless.

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.md with my changes

Sorry, something went wrong.

@shotasilagadzetaal shotasilagadzetaal changed the title force validation feat(ARCO-320): force validation Jan 23, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@boecklim boecklim merged commit 657dd57 into main Jan 23, 2025
7 of 8 checks passed
@boecklim boecklim deleted the add-enforce-validation branch January 23, 2025 12:27
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants