Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: message queue #760

Merged
merged 3 commits into from
Jan 29, 2025
Merged

refactor: message queue #760

merged 3 commits into from
Jan 29, 2025

Conversation

boecklim
Copy link
Collaborator

Description of Changes

  • Move message queue to pkg folder
  • Remove any references to internal folder from pkg folder

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim force-pushed the refactor/message-queue branch 2 times, most recently from 0863bb5 to 5c74182 Compare January 28, 2025 13:55
@boecklim boecklim self-assigned this Jan 28, 2025
@boecklim boecklim marked this pull request as ready for review January 28, 2025 15:16
@boecklim boecklim force-pushed the refactor/message-queue branch from 5c74182 to eccacc0 Compare January 29, 2025 14:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@boecklim boecklim merged commit 35c9328 into main Jan 29, 2025
7 of 8 checks passed
@boecklim boecklim deleted the refactor/message-queue branch January 29, 2025 15:59
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
@boecklim
refactor: message queue (#760)
87ab2c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shotasilagadzetaal shotasilagadzetaal shotasilagadzetaal approved these changes

Assignees

@boecklim boecklim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklim @shotasilagadzetaal