Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BUX-408): admin query requests are failing because of nil reference and invalid http method #173

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

dorzepowski
Copy link
Collaborator

@dorzepowski dorzepowski commented Dec 20, 2023

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner December 20, 2023 10:22
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (62b82cc) 38.83% compared to head (0e07e25) 38.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   38.83%   38.88%   +0.04%     
==========================================
  Files          21       21              
  Lines        2585     2587       +2     
==========================================
+ Hits         1004     1006       +2     
  Misses       1495     1495              
  Partials       86       86              
Flag Coverage Ξ”
unittests 38.88% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
buxclient.go 84.00% <100.00%> (+0.43%) ⬆️
transports/http_admin.go 5.39% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 62b82cc...0e07e25. Read the comment docs.

@mergify mergify bot merged commit 07fecdf into master Dec 20, 2023
7 checks passed
@mergify mergify bot deleted the fix/bux-408-admin-requests branch December 20, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants