Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUX-430/Remove logs and debug flag #176

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

Nazarii-4chain
Copy link
Contributor

Removed logs and debug flag

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@Nazarii-4chain Nazarii-4chain self-assigned this Dec 28, 2023
@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner December 28, 2023 13:38
Copy link
Contributor

mergify bot commented Dec 28, 2023

Welcome to our open-source project @Nazarii-4chain! 💘

@mergify mergify bot added the feature Any new significant addition label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dc9233) 40.36% compared to head (dbe5756) 41.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   40.36%   41.55%   +1.18%     
==========================================
  Files          16       16              
  Lines        2492     2361     -131     
==========================================
- Hits         1006      981      -25     
+ Misses       1400     1302      -98     
+ Partials       86       78       -8     
Flag Coverage Δ
unittests 41.55% <ø> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
buxclient.go 82.85% <ø> (-1.15%) ⬇️
client_options.go 100.00% <ø> (ø)
transports/client_options.go 100.00% <ø> (ø)
transports/graphql.go 49.55% <ø> (+0.68%) ⬆️
transports/graphql_admin.go 5.79% <ø> (+0.06%) ⬆️
transports/http.go 36.86% <ø> (+4.02%) ⬆️
transports/http_admin.go 6.11% <ø> (+0.71%) ⬆️
transports/transports.go 80.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc9233...dbe5756. Read the comment docs.

@Nazarii-4chain Nazarii-4chain changed the title BUX-430/Remove logs and debug fla BUX-430/Remove logs and debug flag Dec 28, 2023
@Nazarii-4chain Nazarii-4chain merged commit 4c3c4f9 into master Dec 29, 2023
7 checks passed
@mergify mergify bot deleted the feat/BUX-430/removeLogs branch December 29, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants