Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(BUX-442): updates readme and code standards #180

Merged
merged 2 commits into from
Jan 19, 2024
Merged

docs(BUX-442): updates readme and code standards #180

merged 2 commits into from
Jan 19, 2024

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Jan 19, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

New version of README, restyled and updated CODE_STANDARDS

@jakubmkowalski jakubmkowalski requested a review from a team as a code owner January 19, 2024 13:59
@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 19, 2024
Copy link
Contributor

mergify bot commented Jan 19, 2024

Welcome to our open-source project @jakubmkowalski! πŸ’˜

@wregulski wregulski assigned jakubmkowalski and unassigned mrz1836 Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (496abed) 46.52% compared to head (410a605) 46.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   46.52%   46.52%           
=======================================
  Files          14       14           
  Lines        1122     1122           
=======================================
  Hits          522      522           
  Misses        543      543           
  Partials       57       57           
Flag Coverage Ξ”
unittests 46.52% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 496abed...410a605. Read the comment docs.

@wregulski wregulski merged commit 032eda5 into bitcoin-sv:master Jan 19, 2024
7 checks passed
@jakubmkowalski jakubmkowalski deleted the docs/updates-readme-and-code_standards branch January 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants