feat(BUX-444): 99% test coverage of main package methods #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to our open-source project @kuba-4chain! π |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
===========================================
+ Coverage 45.63% 56.39% +10.75%
===========================================
Files 15 16 +1
Lines 1192 1197 +5
===========================================
+ Hits 544 675 +131
+ Misses 587 447 -140
- Partials 61 75 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kuba-4chain
force-pushed
the
bux-444-test-coverage
branch
from
9c08466 to
bd0a21f
Compare
pawellewandowski98
approved these changes
Jan 22, 2024
kuba-4chain
force-pushed
the
bux-444-test-coverage
branch
from
bd0a21f to
6b20dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Info
The coverage of the main package is 99% (one if statement cannot be tested). The coverage of
transportspackage shows it's not tested, but actually it is, because the methods are interfaced and are called indirectly from the main package (previously there were also graphql methods, that's why it's interfaced).The admin methods need to be looked into, and there are already tasks for it in JIRA.