Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BUX-191): example in documentation is not working #184

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

dorzepowski
Copy link
Collaborator

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner January 24, 2024 16:07
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (377843e) 43.79% compared to head (01f2621) 45.63%.
Report is 2 commits behind head on master.

❗ Current head 01f2621 differs from pull request most recent head 7c65a08. Consider uploading reports for the commit 7c65a08 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   43.79%   45.63%   +1.84%     
==========================================
  Files          15       15              
  Lines        1192     1192              
==========================================
+ Hits          522      544      +22     
+ Misses        613      587      -26     
- Partials       57       61       +4     
Flag Coverage Ξ”
unittests 45.63% <ΓΈ> (+1.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9829587...7c65a08. Read the comment docs.

@mrz1836 mrz1836 removed their assignment Jan 24, 2024
@dorzepowski dorzepowski force-pushed the fix/not-working-example-in-documentation branch from 01f2621 to 7c65a08 Compare January 24, 2024 16:13
@dorzepowski dorzepowski merged commit 64d97bf into master Jan 24, 2024
5 checks passed
@dorzepowski dorzepowski deleted the fix/not-working-example-in-documentation branch January 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants