Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BUX-600): rename go-buxclient #195

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented Feb 16, 2024

TODO:

  • Update package names for bux-models and bux,
  • Update CODEOWNERS & workflows (other tasks).

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski self-assigned this Feb 16, 2024
@wregulski wregulski requested a review from a team as a code owner February 16, 2024 12:18
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Manual Tests

💚 Manual testing by @arkadiuszos4chain resulted in success.

@wregulski wregulski marked this pull request as draft February 16, 2024 12:27
.github/CODE_STANDARDS.md Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
transports/config.go Outdated Show resolved Hide resolved
@mergify mergify bot added the update General updates label Feb 16, 2024
LICENSE Outdated Show resolved Hide resolved
transports/config.go Outdated Show resolved Hide resolved
@wregulski wregulski marked this pull request as ready for review February 20, 2024 08:48
@wregulski wregulski force-pushed the chore/600-update-name branch from a7ae877 to adcffdf Compare February 22, 2024 09:59
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (42806e5) 59.91% compared to head (6ca6745) 59.91%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   59.91%   59.91%           
=======================================
  Files          16       16           
  Lines         978      978           
=======================================
  Hits          586      586           
  Misses        315      315           
  Partials       77       77           
Flag Coverage Δ
unittests 59.91% <73.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
access_keys.go 100.00% <100.00%> (ø)
client_options.go 100.00% <100.00%> (ø)
destinations.go 100.00% <100.00%> (ø)
fixtures/fixtures.go 60.00% <ø> (ø)
paymail_addresses.go 100.00% <100.00%> (ø)
transactions.go 100.00% <100.00%> (ø)
transports/errors.go 72.72% <100.00%> (ø)
transports/transports.go 83.33% <100.00%> (ø)
walletclient.go 96.29% <100.00%> (ø)
xpubs.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42806e5...6ca6745. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain added the tested PR was tested by a team member label Feb 22, 2024
@wregulski wregulski merged commit e801606 into master Feb 22, 2024
8 checks passed
@wregulski wregulski deleted the chore/600-update-name branch February 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants