Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-679): directed secret #222

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat(SPV-679): directed secret #222

merged 2 commits into from
Apr 25, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Apr 24, 2024 •
edited
Loading

The (sharedSecret+paymail) is a "directedSecret". This ensures that:
passcodeForBob-from-Alice != passcodeForAlice-from-Bob.

Basic flow:
Alice generates passcodeForBob with (sharedSecret+(contact.Paymail as bobPaymail))
Alice sends passcodeForBob to Bob (e.g. via email)
Bob validates passcodeForBob with (sharedSecret+(requesterPaymail as bobPaymail))

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner April 24, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @Nazarii-4chain resulted in success.

@Nazarii-4chain Nazarii-4chain added the tested PR was tested by a team member label Apr 25, 2024
@chris-4chain chris-4chain merged commit c8a64a8 into main Apr 25, 2024
9 checks passed
@chris-4chain chris-4chain deleted the feat-directed-secret branch April 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nazarii-4chain Nazarii-4chain Nazarii-4chain approved these changes

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-4chain @dorzepowski @arkadiuszos4chain @Nazarii-4chain