Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-851) add Go examples aligned with js-client #238

Merged
merged 4 commits into from
Jun 19, 2024
Merged

feat(SPV-851) add Go examples aligned with js-client #238

merged 4 commits into from
Jun 19, 2024

Conversation

yarex-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@yarex-4chain yarex-4chain self-assigned this Jun 12, 2024
@yarex-4chain yarex-4chain requested a review from a team as a code owner June 12, 2024 21:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @wregulski resulted in success.

chris-4chain
chris-4chain reviewed Jun 13, 2024
View reviewed changes
examples/utils.go Outdated Show resolved Hide resolved
examples/utils.go Show resolved Hide resolved
examples/list_transactions/list_transactions.go Outdated Show resolved Hide resolved
wregulski
wregulski requested changes Jun 13, 2024
View reviewed changes
examples/Makefile Outdated Show resolved Hide resolved
examples/example_keys.go Outdated Show resolved Hide resolved
examples/Makefile Outdated Show resolved Hide resolved
@yarex-4chain yarex-4chain force-pushed the feat/SPV-796-adjust-go-examples branch from f25b9cf to 2580745 Compare June 14, 2024 14:10
@wregulski
Copy link
Contributor

testing

@wregulski wregulski added the tested PR was tested by a team member label Jun 19, 2024
@yarex-4chain yarex-4chain merged commit 73404c9 into main Jun 19, 2024
6 checks passed
@yarex-4chain yarex-4chain deleted the feat/SPV-796-adjust-go-examples branch June 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain left review comments

@wregulski wregulski wregulski approved these changes

Assignees

@yarex-4chain yarex-4chain

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yarex-4chain @wregulski @chris-4chain