Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-879): TOTP example & all examples adjustments #241

Merged
merged 2 commits into from
Jun 19, 2024
Merged

feat(SPV-879): TOTP example & all examples adjustments #241

merged 2 commits into from
Jun 19, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jun 19, 2024 •
edited
Loading

I've added a generate_totp example, equivalent to js-client https://github.com/bitcoin-sv/spv-wallet-js-client/blob/main/examples/generate-totp.ts

Additionally I've adjusted examples/go.mod:

  • golang version: to match what is defined in the "root" go.mod
  • module name: to omit quite confusing import "examples" - not only I was confused about that but also the autoformatter that was placing it into "external" packages group - and then GCI linter was showing warning 🙈

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner June 19, 2024 10:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @yarex-4chain resulted in success.

Nazarii-4chain
Nazarii-4chain reviewed Jun 19, 2024
View reviewed changes
examples/utils.go Outdated Show resolved Hide resolved
yarex-4chain
yarex-4chain reviewed Jun 19, 2024
View reviewed changes
examples/utils.go Outdated Show resolved Hide resolved
examples/example_keys.go Show resolved Hide resolved
@yarex-4chain yarex-4chain added the tested PR was tested by a team member label Jun 19, 2024
@chris-4chain chris-4chain merged commit cd0f796 into main Jun 19, 2024
9 checks passed
@chris-4chain chris-4chain deleted the totp-example branch June 19, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarex-4chain yarex-4chain yarex-4chain approved these changes

@Nazarii-4chain Nazarii-4chain Nazarii-4chain approved these changes

@wregulski wregulski wregulski approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-4chain @wregulski @Nazarii-4chain @yarex-4chain