Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-839): add requesterPaymail into upsert contact method #243

Merged
merged 1 commit into from
Jun 24, 2024
Merged

feat(SPV-839): add requesterPaymail into upsert contact method #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contacts_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func TestContactActionsRouting(t *testing.T) {
})

t.Run("UpsertContact", func(t *testing.T) {
contact, err := client.UpsertContact(context.Background(), "test-id", "[email protected]", nil)
contact, err := client.UpsertContact(context.Background(), "test-id", "[email protected]", "", nil)
require.NoError(t, err)
require.NotNil(t, contact)
})
Expand Down
4 changes: 2 additions & 2 deletions http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,8 +623,8 @@ func (wc *WalletClient) GetContacts(ctx context.Context, conditions *filter.Cont
}

// UpsertContact add or update contact. When adding a new contact, the system utilizes Paymail's PIKE capability to dispatch an invitation request, asking the counterparty to include the current user in their contacts.
func (wc *WalletClient) UpsertContact(ctx context.Context, paymail, fullName string, metadata map[string]any) (*models.Contact, ResponseError) {
return wc.UpsertContactForPaymail(ctx, paymail, fullName, metadata, "")
func (wc *WalletClient) UpsertContact(ctx context.Context, paymail, fullName, requesterPaymail string, metadata map[string]any) (*models.Contact, ResponseError) {
return wc.UpsertContactForPaymail(ctx, paymail, fullName, metadata, requesterPaymail)
}

// UpsertContactForPaymail add or update contact. When adding a new contact, the system utilizes Paymail's PIKE capability to dispatch an invitation request, asking the counterparty to include the current user in their contacts.
Expand Down
Loading