Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SPV-000): update to spv-wallet's version beta.23 #263

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner August 23, 2024 09:24
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@@ -22,7 +22,7 @@ func main() {
client := walletclient.NewWithXPriv(server, examples.ExampleXPriv)
ctx := context.Background()

recipient := walletclient.Recipients{To: "[email protected]", Satoshis: 1}
recipient := walletclient.Recipients{To: "[email protected]", Satoshis: 1}
Copy link
Contributor

@wregulski wregulski Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘€ πŸ‘Ά

Copy link
Contributor

@Nazarii-4chain Nazarii-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wregulski
Copy link
Contributor

testing

@wregulski wregulski added the tested PR was tested by a team member label Aug 23, 2024
@chris-4chain chris-4chain merged commit b2cf4f7 into main Aug 23, 2024
9 of 10 checks passed
@chris-4chain chris-4chain deleted the update-spvwallet-dependency branch August 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants