Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1296): add method to create contact by admin #307

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented Dec 16, 2024

This pull request introduces a new function to the http.go file, specifically for creating a new contact via an HTTP POST request. This addition enhances the functionality of the WalletClient by allowing the creation of contacts with specified details.

New functionality:

  • http.go: Added the AdminCreateContact function to enable the creation of a new contact using the specified paymail, creator paymail, full name, and metadata.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski added the feature Any new significant addition label Dec 16, 2024
@wregulski wregulski self-assigned this Dec 16, 2024
@wregulski wregulski requested a review from a team as a code owner December 16, 2024 20:19
Copy link
Contributor

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Manual Tests

💚 Manual testing by @jakubmkowalski resulted in success.

@jakubmkowalski jakubmkowalski added the tested PR was tested by a team member label Dec 16, 2024
@jakubmkowalski
Copy link
Contributor

There is a problem with the mapping of created_at and updated_at, a task in jira.
tests passed

@wregulski wregulski added the regression-tests Runs regression tests label Dec 17, 2024
@wregulski wregulski merged commit 155281c into main Dec 17, 2024
21 of 24 checks passed
@wregulski wregulski deleted the feat/spv-1296 branch December 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants