Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(SPV-1413) add method for getting webhooks to admin client #317

Merged
merged 7 commits into from
Jan 24, 2025
Merged

Feat(SPV-1413) add method for getting webhooks to admin client #317

merged 7 commits into from
Jan 24, 2025

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Jan 24, 2025

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@ac4ch ac4ch requested a review from a team as a code owner January 24, 2025 06:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

ac4ch added 2 commits January 24, 2025 07:29
@ac4ch
feat(spv-1413) corrected test per review comment
e8bc814
@ac4ch
Merge branch 'feat/SPV-1413/add_method_for_getting_webhooks_to_admin_…
266d2aa 
…client' of github.com:bitcoin-sv/spv-wallet-go-client into feat/SPV-1413/add_method_for_getting_webhooks_to_admin_client
@ac4ch ac4ch requested a review from mgosek-4chain January 24, 2025 06:35
@ac4ch ac4ch enabled auto-merge (squash) January 24, 2025 06:59
chris-4chain
chris-4chain requested changes Jan 24, 2025
View reviewed changes
admin_api.go Outdated Show resolved Hide resolved
internal/api/v1/admin/webhooks/webhooks_api.go Outdated Show resolved Hide resolved
ac4ch and others added 2 commits January 24, 2025 11:50
@ac4ch ac4ch requested a review from chris-4chain January 24, 2025 10:50
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jan 24, 2025
@ac4ch ac4ch merged commit 9b46040 into main Jan 24, 2025
10 checks passed
@ac4ch ac4ch deleted the feat/SPV-1413/add_method_for_getting_webhooks_to_admin_client branch January 24, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgosek-4chain mgosek-4chain mgosek-4chain approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ac4ch @chris-4chain @mgosek-4chain