Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-898): replaces with go sdk #731

Merged
merged 27 commits into from
Oct 15, 2024
Merged

Conversation

wregulski
Copy link
Contributor

No description provided.

@wregulski wregulski self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.64894% with 163 lines in your changes missing coverage. Please review.

Project coverage is 46.39%. Comparing base (094bcae) to head (810dc04).

Files with missing lines Patch % Lines
engine/paymail_service_provider.go 20.00% 16 Missing ⚠️
server/middleware/signature_middleware.go 0.00% 16 Missing ⚠️
engine/utils/merkletree.go 0.00% 14 Missing ⚠️
engine/model_bump.go 27.77% 13 Missing ⚠️
engine/ef_tx.go 36.84% 11 Missing and 1 partial ⚠️
engine/utils/destination_types.go 60.00% 5 Missing and 5 partials ⚠️
engine/utils/ripemd160.go 0.00% 10 Missing ⚠️
engine/model_draft_transactions.go 84.61% 4 Missing and 4 partials ⚠️
models/bsv/fee_unit.go 0.00% 8 Missing ⚠️
engine/model_destinations.go 37.50% 3 Missing and 2 partials ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   46.83%   46.39%   -0.44%     
==========================================
  Files         325      328       +3     
  Lines       13322    13367      +45     
==========================================
- Hits         6239     6202      -37     
- Misses       6518     6595      +77     
- Partials      565      570       +5     
Flag Coverage Δ
unittests 46.39% <56.64%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
config/config_to_options.go 0.00% <ø> (ø)
engine/beef_tx.go 48.78% <100.00%> (ø)
engine/beef_tx_bytes.go 95.45% <100.00%> (+0.10%) ⬆️
engine/beef_tx_sorting.go 100.00% <100.00%> (ø)
engine/chainstate/broadcast_client_init.go 65.00% <100.00%> (ø)
engine/chainstate/transaction.go 52.94% <100.00%> (ø)
engine/model_access_keys.go 65.88% <100.00%> (ø)
engine/model_paymail_addresses.go 70.11% <100.00%> (ø)
engine/pike/pike.go 70.00% <100.00%> (ø)
engine/script/template/p2pkh.go 100.00% <100.00%> (ø)
... and 35 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094bcae...810dc04. Read the comment docs.

@wregulski wregulski marked this pull request as ready for review October 14, 2024 10:37
@wregulski wregulski requested a review from a team as a code owner October 14, 2024 10:37
@wregulski wregulski changed the title DRAFT(SPV-898): replaces with go sdk feat(SPV-898): replaces with go sdk Oct 14, 2024
@wregulski wregulski added the regression-tests Runs regression tests label Oct 14, 2024
@wregulski wregulski added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Oct 14, 2024
engine/chainstate/client.go Outdated Show resolved Hide resolved
models/bsv/fee_unit.go Show resolved Hide resolved
Copy link
Contributor

@ac4ch ac4ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, except @chris-4chain comments per conflicts and duplicated work i am ok with ur changes.

engine/beef_tx_bytes.go Show resolved Hide resolved
config/config_to_options.go Outdated Show resolved Hide resolved
engine/beef_tx_bytes.go Outdated Show resolved Hide resolved
engine/beef_tx_sorting.go Outdated Show resolved Hide resolved
engine/beef_tx_sorting.go Outdated Show resolved Hide resolved
engine/beef_tx_sorting.go Outdated Show resolved Hide resolved
engine/ef_tx.go Outdated Show resolved Hide resolved
engine/utils/merkletree.go Outdated Show resolved Hide resolved
engine/utils/ripemd160.go Outdated Show resolved Hide resolved
engine/utils/ripemd160.go Outdated Show resolved Hide resolved
@wregulski wregulski added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Oct 15, 2024
@chris-4chain chris-4chain added the tested PR was tested by a team member label Oct 15, 2024
@wregulski wregulski merged commit 89eca8f into main Oct 15, 2024
18 of 20 checks passed
@wregulski wregulski deleted the feat/spv-898-replaces-with-go-sdk branch October 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants