Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spike): oapi codegen prove of concept #859

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.28571% with 96 lines in your changes missing coverage. Please review.

Project coverage is 46.67%. Comparing base (b06ac5a) to head (d8d23c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/spec.gen.go 52.80% 52 Missing and 7 partials ⚠️
api/scopes_middleware.go 35.71% 12 Missing and 6 partials ⚠️
actions/testapi_user.go 63.41% 12 Missing and 3 partials ⚠️
server/server.go 62.50% 2 Missing and 1 partial ⚠️
tools/apigen.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   46.58%   46.67%   +0.08%     
==========================================
  Files         390      396       +6     
  Lines       18524    18734     +210     
==========================================
+ Hits         8630     8744     +114     
- Misses       9204     9283      +79     
- Partials      690      707      +17     
Flag Coverage Δ
unittests 46.67% <54.28%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/server_implementation.go 100.00% <100.00%> (ø)
actions/testapi_admin.go 100.00% <100.00%> (ø)
tools/apigen.go 0.00% <0.00%> (ø)
server/server.go 12.19% <62.50%> (+5.43%) ⬆️
actions/testapi_user.go 63.41% <63.41%> (ø)
api/scopes_middleware.go 35.71% <35.71%> (ø)
api/spec.gen.go 52.80% <52.80%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06ac5a...d8d23c8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants