Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1125) finalize the story for op_return recording #877

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner January 29, 2025 06:09
Copy link

github-actions bot commented Jan 29, 2025

Manual Tests

πŸ’š Manual testing by @mgosek-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 64.49275% with 49 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (0f4e6b8) to head (98d524a).

Files with missing lines Patch % Lines
models/bsv/outpoint.go 0.00% 23 Missing ⚠️
actions/v2/data/get.go 50.00% 9 Missing and 3 partials ⚠️
engine/v2/database/repository/data.go 66.66% 6 Missing and 2 partials ⚠️
engine/v2/data/data_service.go 70.00% 2 Missing and 1 partial ⚠️
engine/client.go 33.33% 2 Missing ⚠️
actions/v2/operations/search.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   52.61%   52.71%   +0.09%     
==========================================
  Files         376      382       +6     
  Lines       16895    17029     +134     
==========================================
+ Hits         8889     8976      +87     
- Misses       7291     7332      +41     
- Partials      715      721       +6     
Flag Coverage Ξ”
unittests 52.71% <64.49%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/v2/data/internal/mapping/data.go 100.00% <100.00%> (ΓΈ)
actions/v2/data/routes.go 100.00% <100.00%> (ΓΈ)
actions/v2/register.go 100.00% <100.00%> (ΓΈ)
engine/client_internal.go 68.59% <100.00%> (+0.61%) ⬆️
engine/testabilities/fixture_engine.go 92.25% <ΓΈ> (ΓΈ)
engine/testabilities/fixture_faucet.go 100.00% <100.00%> (ΓΈ)
engine/v2/data/datamodels/data.go 100.00% <100.00%> (ΓΈ)
engine/v2/database/repository/all.go 100.00% <100.00%> (ΓΈ)
actions/v2/operations/search.go 34.37% <66.66%> (ΓΈ)
engine/client.go 55.92% <33.33%> (-0.46%) ⬇️
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0f4e6b8...98d524a. Read the comment docs.

actions/v2/operations/search.go Show resolved Hide resolved
actions/v2/transactions/outlines_record_test.go Outdated Show resolved Hide resolved
engine/v2/data/interface.go Outdated Show resolved Hide resolved
actions/v2/data/routes.go Show resolved Hide resolved
@mgosek-4chain mgosek-4chain added the tested PR was tested by a team member label Jan 30, 2025
@chris-4chain chris-4chain merged commit 3893827 into main Jan 30, 2025
13 checks passed
@chris-4chain chris-4chain deleted the feat/SPV-1125-finalize branch January 30, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants