Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SPV-1350): (v1) update tx in db when sth changed #904

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner February 11, 2025 09:07
Copy link

github-actions bot commented Feb 11, 2025

Manual Tests

πŸ’š Manual testing by @jakubmkowalski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (9494183) to head (0924a91).

Files with missing lines Patch % Lines
engine/tx_sync_task.go 0.00% 25 Missing ⚠️
engine/model_transactions.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   52.75%   52.71%   -0.05%     
==========================================
  Files         406      406              
  Lines       17993    18007      +14     
==========================================
  Hits         9493     9493              
- Misses       7749     7763      +14     
  Partials      751      751              
Flag Coverage Ξ”
unittests 52.71% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
engine/model_transactions.go 63.88% <0.00%> (-0.72%) ⬇️
engine/tx_sync_task.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9494183...0924a91. Read the comment docs.

@wregulski wregulski added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Feb 11, 2025
@jakubmkowalski jakubmkowalski added the tested PR was tested by a team member label Feb 12, 2025
@chris-4chain chris-4chain added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Feb 12, 2025
@chris-4chain chris-4chain merged commit 4dfe353 into main Feb 12, 2025
13 checks passed
@chris-4chain chris-4chain deleted the fix/SPV-1350 branch February 12, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants