Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select tx change with utxo selector #915

Merged

Conversation

dorzepowski
Copy link
Collaborator

Example how we could use selector to calculate change, to not calculate it twice

@dorzepowski dorzepowski requested a review from a team as a code owner February 18, 2025 14:15
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.67470% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.70%. Comparing base (a44d0a4) to head (4cfa9f7).

Files with missing lines Patch % Lines
...al/sql/testabilities/assertions_inputs_selector.go 0.00% 11 Missing ⚠️
...ion/outlines/testabilities/mocked_utxo_selector.go 0.00% 6 Missing ⚠️
...ine/v2/database/testabilities/user_utxo_fixture.go 0.00% 3 Missing ⚠️
engine/v2/transaction/outlines/transaction_spec.go 50.00% 2 Missing and 1 partial ⚠️
...transaction/outlines/utxo/internal/sql/selector.go 83.33% 2 Missing ⚠️
...e/v2/transaction/outlines/inputs_specifications.go 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feat/SPV-1059-fee-and-change     #915      +/-   ##
================================================================
- Coverage                         36.81%   36.70%   -0.11%     
================================================================
  Files                               413      413              
  Lines                             19466    19423      -43     
================================================================
- Hits                               7166     7129      -37     
+ Misses                            11713    11709       -4     
+ Partials                            587      585       -2     
Flag Coverage Δ
unittests 36.70% <68.67%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gine/v2/database/testabilities/fixture_database.go 0.00% <ø> (ø)
engine/v2/transaction/outlines/add_change.go 64.28% <100.00%> (ø)
...e/v2/transaction/outlines/output_specifications.go 76.00% <100.00%> (ø)
...lines/testabilities/fixture_outline_transaction.go 0.00% <ø> (ø)
...ction/outlines/utxo/internal/sql/calculate_size.go 100.00% <100.00%> (ø)
...utlines/utxo/internal/sql/inputs_query_composer.go 100.00% <100.00%> (ø)
...e/v2/transaction/outlines/inputs_specifications.go 93.75% <95.00%> (-0.49%) ⬇️
...transaction/outlines/utxo/internal/sql/selector.go 78.12% <83.33%> (+5.54%) ⬆️
...ine/v2/database/testabilities/user_utxo_fixture.go 0.00% <0.00%> (ø)
engine/v2/transaction/outlines/transaction_spec.go 89.28% <50.00%> (+0.39%) ⬆️
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44d0a4...4cfa9f7. Read the comment docs.

@chris-4chain chris-4chain merged commit af0460c into feat/SPV-1059-fee-and-change Feb 19, 2025
8 checks passed
@chris-4chain chris-4chain deleted the spv-1059-select-change-with-selector branch February 19, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants