BIP159 updates #1768
Merged
BIP159 updates #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
added
Proposed BIP modification
Pending acceptance
jonatack
force-pushed
the
2025-02-bip159
branch
from
0617b31 to
1b17eea
Compare
|
Did another pass and seems ready for review. |
jonatack
force-pushed
the
2025-02-bip159
branch
from
1b17eea to
b680873
Compare
|
Updated the second commit per review feedback: 1b17eea..b680873 |
|
(I might propose adding a changelog to this BIP if this moves forward.) |
jonatack
force-pushed
the
2025-02-bip159
branch
from
b680873 to
b3e6e24
Compare
|
Updated to take the feedback from @jonasschnelli and @murchandamus (thanks!) and it looks much better. Please let me know what you think. |
There was a problem hiding this comment.
ACK b3e6e24
Good improvement, one optional nit, if you feel like taking it.
e.g. that NODE_NETWORK is not set See reference implementation bitcoin/bitcoin#10387 and this comment in that pull bitcoin/bitcoin#10387 (comment)
Not the same meaning, so not a purely editorial fixup, but I think "unwittingly" expresses the intended meaning.
jonatack
force-pushed
the
2025-02-bip159
branch
from
b3e6e24 to
22f7f04
Compare
|
Thanks @jonasschnelli and @murchandamus for the second round of review. Took your suggestions, added a missing |
|
ACK d44f70e |
murchandamus
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few clarifications following a discussion with BIP author Jonas Schnelli yesterday and then thanks to review feedback from both Jonas and Murch.
These are compatible with the reference implementation in the BIP and with the current implementation in Bitcoin Core.
It is worthwhile to read the discussion in reference implementation bitcoin/bitcoin#10387 (particularly bitcoin/bitcoin#10387 (comment)).