Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API surface of the Wallet type #596

Closed
14 tasks done
thunderbiscuit opened this issue Sep 26, 2024 · 3 comments
Closed
14 tasks done

API surface of the Wallet type #596

thunderbiscuit opened this issue Sep 26, 2024 · 3 comments

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Sep 26, 2024

After taking some time to look at what parts of the Wallet API were available/not available/useful for the bindings, many methods stood out. This issue will track them. Note that not all of those are top priority, but most of them we figured would be useful and not too costly to include either in the first version of the 1.0 or in a future feature release (1.1, 1.2, etc.)

  • Wallet::peek_address
  • Wallet::cancel_tx
  • Wallet::next_derivation_index
  • Wallet::derivation_of_spk
  • Wallet::descriptor_checksum
  • Wallet::finalize_psbt
  • Wallet::get_utxo
  • Wallet::list_unused_addresses
  • Wallet::mark_used
  • Wallet::next_unused_address
  • Wallet::policies
  • Wallet::public_descriptor
  • Wallet::reveal_addresses_to
  • Wallet::unbroadcast_transactions
@rustaceanrob
Copy link
Contributor

What I would consider high priority:finalize_psbt, cancel_tx, public_descriptor, descriptor_checksum. I can hack at those if others agree they should be included in 1.0

@thunderbiscuit thunderbiscuit mentioned this issue Oct 7, 2024
5 tasks
@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Oct 7, 2024

The Wallet::unbroadcast_transactions method requires exposing the TxNode type, which is a bit more than I want to do at the moment for a method no one has asked directly.

I'd be great to define the exact use case for this (I think its about creating unbroadcast transactions so as to lock the UTXOs for transaction builder, and eventually to take stock maybe of those tx we've created and maybe want to cancel using cancel_tx()? Need to dig a bit more).

@thunderbiscuit
Copy link
Member Author

With the merge of #626 and #625 this list will be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants