-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet apis #601
Add wallet apis #601
Conversation
79dcf13
to
c8a8983
Compare
The two remaining methods we talked about exposing (Wallet::policies and Wallet::public_descriptor) require returning a simplified version of the Rust return type or adding new types we don't currently have. I think both of those might be fine just returning strings (a policy string/json and a descriptor) but at the same time if we change our mind later we'll create a breaking change by switching the return type of the methods. I'm thinking we can merge this PR as is and punt on those 2 methods which are not super requested and simply add them in a 1.1 release (or one of the later betas if we go to 6 and 7), potentially with their full types or simply strings after more discussion with the team. This way these methods can make it into the beta 5 release and we can move on to the TxBuilder methods we want to add (see #597). What do you think @reez @notmandatory @rustaceanrob? |
My main fixation on |
Pull request LGTM |
@rustaceanrob yeah true that we 100% need to make sure people can export/save. The reason I think we could get away with it is that right now the Mind you we could just decide to return the public descriptor string too. We have a bit of time to think about it before the final 1.0 on the Rust side I think. Eventually I do think that a more complete exposition of the Descriptor types and their inner parts might be nice to have for us, because right now at the ffi layer you get much less than you do in Rust for those types, including things like rust-bitcoin keys stuff (PublicKey, ExtendedKey, etc.). One of the hiccups for them is that they're absolutely chuck-full of generics, so they need a bit of massaging. Maybe a job for bitcoin-ffi? |
ACK c8a8983 Can merge, and I think those final two things still to expose I'm interested in discussing more per #605 and bitcoindevkit/BDKSwiftExampleWallet#230 |
This PR brings in more
Wallet
APIs listed in #596. Draft for now, I'll see about adding as much as I can today/tomorrow.Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: