Update bdk version to 1.0.0-alpha.2 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
1.0-work
branch
from
a81a4ab to
aba5278
Compare
thunderbiscuit
force-pushed
the
1.0-work
branch
14 times, most recently
from
af40823 to
6a5126d
Compare
thunderbiscuit
force-pushed
the
1.0-work
branch
13 times, most recently
from
214cb24 to
8cf8320
Compare
thunderbiscuit
force-pushed
the
1.0-work
branch
3 times, most recently
from
872f8e9 to
2541a92
Compare
reez
reviewed
Oct 18, 2023
There was a problem hiding this comment.
I have tested this branch locally
Just calling out a couple high level changes here for reference:
- Related adding of
esplora.rsand removal ofblockchain.rs - Some changes to scripts and .sh files related to removal of workspace
database.rsremoved and will be reimplemented in some different form in follow up PR'spsbt.rsfully commented out but stays because we know it will be implemented fully in follow up PR's
bdk-android/lib/src/androidTest/kotlin/org/bitcoindevkit/AndroidLibTest.kt
Outdated
Show resolved
Hide resolved
|
nice job thunder!!! 🚀 |
8 tasks
5 tasks
thunderbiscuit
changed the title
This is a big change that updates some of our build infrastructure as well as upgrading the bdk dependency. It adds the simple new_no_persist constructor on the wallet as well as the blocking esplora client.
thunderbiscuit
force-pushed
the
1.0-work
branch
from
2541a92 to
790aee9
Compare
notmandatory
approved these changes
Oct 23, 2023
This was referenced Nov 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the beginning of the migration to the new 1.0 API for the bitcoin development kit bindings.
Notes to the reviewers
This is likely to be a fairly big PR; let's review it one commit at a time.
Changelog notice
Oh lordy lord the changelog on this thing