Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add/update android+ios readme example project links #416

Merged
merged 1 commit into from
Nov 17, 2023
Merged

docs: add/update android+ios readme example project links #416

merged 1 commit into from
Nov 17, 2023

Conversation

reez
Copy link
Collaborator

@reez reez commented Nov 16, 2023 •
edited
Loading

Description

Updating the respective README's per Android and iOS example projects recently added to the bitcoindevkit org.

Notes to the reviewers

Android link was added to existing links, iOS link was updated to point to correct repo on bitcoindevkit org.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez marked this pull request as ready for review November 16, 2023 15:41
@reez reez requested review from notmandatory and thunderbiscuit and removed request for notmandatory November 16, 2023 19:13
thunderbiscuit
thunderbiscuit approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b8778cd.

@thunderbiscuit thunderbiscuit merged commit b8778cd into bitcoindevkit:master Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit