-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust compiler 1.77.1 on python ci runs #518
Conversation
WalkthroughThe recent updates involve streamlining the Rust compiler version definition in Python CI workflows within GitHub Actions. The changes focus on replacing explicit Rust toolchain configurations previously set using Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
e6f60ec
to
c0dd8da
Compare
Example test run of this PR triggered manually here: https://github.com/bitcoindevkit/bdk-ffi/actions/runs/9033520723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ac15ed7
This PR initially tried to remove the "unused" action toolchain@v1. This turned out not to be true, because while the exact Rust compiler version is now defined in the scripts, Rust must be installed already for those steps to have access to rustup in the first place.
The one improvement done here is that the correct version of Rust is downloaded in the first place on the CI, so we don't download the sable version only to then download a second version when the shell script starts. We save one round of downloads. Note that the rustup command to use 1.77.1 must stay in the shell scripts for people building locally.
Fixes #404