Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci test-swift from macos-12 to macos-13 #618

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: ci test-swift from macos-12 to macos-13 #618

merged 1 commit into from
Nov 6, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Nov 4, 2024 •
edited
Loading

Description

Attempts to fix CI failures when I ran CI on #617

macos bdk-ffi pr

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez
Copy link
Collaborator Author

reez commented Nov 4, 2024

CI succeeded on my fork https://github.com/reez/bdk-ffi/actions/runs/11670762413/job/32495646310

@reez reez marked this pull request as ready for review November 4, 2024 21:15
@reez reez changed the title (draft) chore: ci test-swift from macos-12 to macos-13 chore: ci test-swift from macos-12 to macos-13 Nov 4, 2024
@reez reez mentioned this pull request Nov 6, 2024
Merged
8 tasks
@reez reez requested a review from thunderbiscuit November 6, 2024 04:00
thunderbiscuit
thunderbiscuit approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8c71fb7.

@thunderbiscuit thunderbiscuit merged commit 8c71fb7 into bitcoindevkit:master Nov 6, 2024
@reez reez deleted the test-swift branch November 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit