Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get_height to esplora #623

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: add get_height to esplora #623

merged 1 commit into from
Nov 8, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Nov 6, 2024 •
edited
Loading

Description

Attempt to solve #547 using get_height

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez linked an issue Nov 6, 2024 that may be closed by this pull request
Bring back getHeight() #547
Closed
@reez reez marked this pull request as ready for review November 6, 2024 03:52
@reez reez requested a review from thunderbiscuit November 6, 2024 03:59
thunderbiscuit
thunderbiscuit approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK c32c72f.

@thunderbiscuit thunderbiscuit merged commit 20eebc8 into bitcoindevkit:master Nov 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring back getHeight()
2 participants
@reez @thunderbiscuit