Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ui_tabs accessible #137

Open
hannahbit opened this issue Sep 4, 2024 · 0 comments
Open

Make ui_tabs accessible #137

hannahbit opened this issue Sep 4, 2024 · 0 comments

Comments

@hannahbit
Copy link
Contributor

The way ui_tabs works atm, the rendered HTML does not comply with accessibility standards.

To fix this we would need to replace the <ul> with a <div role="tablist"> and instead of nesting the buttons inside <li>s they would need to be the direct children of the div and have a role="tab" set.
hannahbit added a commit that referenced this issue Oct 10, 2024
@hannahbit
[#137] Make ui_tabs accessible
e92760b 
#137
@hannahbit hannahbit mentioned this issue Oct 10, 2024
Merged
hannahbit added a commit that referenced this issue Oct 23, 2024
@hannahbit
[#137] Make ui_tabs accessible (#139)
eb93701 
* [#137] Make ui_tabs accessible

#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannahbit