-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#137] Make ui_tabs accessible #139
Conversation
I think this would be just needing a CHANGELOG entry and then be good to go.
Since one can always set another |
The code and the generated docs look fine 👍 What does not work for me is the demo application though. Is it known to be broken or is this a new thing? |
It's the same on |
@andreasknoepfle @klappradla Thanks for the reviews 🧡 I updated the changelog. Can you take another look? |
CHANGELOG.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
## Unreleased | |||
|
|||
- Changed `ui_tabs` and `ui_tab_button` to follow accessibility guidelines. As a side effect the gap between the tabs is now a little smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth mentioning what you wrote in the issue
replace the
<ul>
with a<div role="tablist">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for 🌊 I'd say.
Fixes the
ui_tabs
not following accessibility guidelines.See issue: #137