Improve response predicates

src/Database/Bloodhound/Internal/Client/BHRequest.hs

@@ -304,7 +304,7 @@ eitherDecodeResponse ::
 eitherDecodeResponse = eitherDecode . responseBody . getResponse
 
 -- | Was there an optimistic concurrency control conflict when
--- indexing a document?
+-- indexing a document? (Check '409' status code.)
 isVersionConflict :: BHResponse parsingContext a -> Bool
 isVersionConflict = statusCheck (== 409)
 

tests/Test/DocumentsSpec.hs

@@ -38,6 +38,21 @@ spec =
           Right (res', _) -> liftIO $ isVersionConflict res' `shouldBe` True
           Left e -> liftIO $ errorStatus e `shouldBe` Just 409
 
+    it "can use predicates on the response" $
+      withTestEnv $ do
+        let ev = ExternalDocVersion minBound
+        let cfg = defaultIndexDocumentSettings {idsVersionControl = ExternalGT ev}
+        resetIndex
+        (res, _) <- insertData' cfg
+        liftIO $ isCreated res `shouldBe` True
+        liftIO $ isSuccess res `shouldBe` True
+        liftIO $ isVersionConflict res `shouldBe` False
+
+        res' <- insertData'' cfg
+        liftIO $ isCreated res' `shouldBe` False
+        liftIO $ isSuccess res' `shouldBe` False
+        liftIO $ isVersionConflict res' `shouldBe` True
+
     it "indexes two documents in a parent/child relationship and checks that the child exists" $
       withTestEnv $ do
         resetIndex

tests/TestsUtils/Common.hs

@@ -205,6 +205,13 @@ insertData' ids = do
   _ <- performBHRequest $ refreshIndex testIndex
   return r
 
+-- | Returns the `BHResponse` of `indexDocument` without any parsing
+insertData'' :: IndexDocumentSettings -> BH IO (BHResponse StatusDependant IndexedDocument)
+insertData'' ids = do
+  r <- dispatch $ indexDocument testIndex ids exampleTweet (DocId "1")
+  _ <- performBHRequest $ refreshIndex testIndex
+  return r
+
 insertTweetWithDocId :: Tweet -> Text -> BH IO IndexedDocument
 insertTweetWithDocId tweet docId = do
   let ids = defaultIndexDocumentSettings