Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BITAMKER-3568: Correctly display job information for jobs with spiders marked as deleted #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reqhiem
Copy link
Contributor

@reqhiem reqhiem commented Aug 21, 2023

Description

When making a new deploy, it is possible that we remove some spiders that are no longer needed. In this case, spiders are marked as deleted in the database.
We have noticed that this causes issues such as the spider field not displaying correctly for the job and the data from the job not being retrieved.

Issue

https://tasks.bitmaker.dev/issues/3568

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@reqhiem reqhiem requested a review from mgonnav August 21, 2023 14:03
@reqhiem reqhiem self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant