Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enh)estela-api: Improve data deletion and add a small fix #238

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

mgonnav
Copy link
Contributor

@mgonnav mgonnav commented Dec 14, 2023

Description

  • Data deletion is currently very slow for projects with large quantities of items due to a call to delete_many({}) which is not really needed.
  • Add a small fix and refactor when calling the get_collection_name method in the job_data.py views.

Issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@mgonnav mgonnav requested a review from Adriana618 December 14, 2023 20:03
@mgonnav mgonnav self-assigned this Dec 14, 2023
@mgonnav mgonnav requested a review from joaquingx December 14, 2023 20:04
@mgonnav mgonnav merged commit 702bdd6 into main Jan 9, 2024
1 check passed
@mgonnav mgonnav deleted the data-delete-fix branch January 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant