Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Optimize Dockerfiles #241

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[MRG] Optimize Dockerfiles #241

merged 2 commits into from
Feb 8, 2024

Conversation

joaquingx
Copy link
Contributor

@joaquingx joaquingx commented Feb 5, 2024

Description

  • Update dockerfiles.

Issue

  • Github Issue ID.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@mgonnav
Copy link
Contributor

mgonnav commented Feb 8, 2024

@joaquingx I have optimized the Dockerfiles, drastically reducing the Dockerfile sizes and improving security. The changes I integrated yield the following improvements in Dockefile sizes:

  • estela-django-api: 1.25GB -> 373MB
  • estela-celery-beat: 1.25GB -> 373MB
  • estela-celery-worker: 1.25GB -> 373MB
  • estela-build-project: 1.65GB -> 879MB
  • queue-consumer: 1.04GB -> 210MB

I have tested deploying a project and running a couple of jobs with the updated Dockefiles, and it has worked fine for me. Please also test it on your side.

@mgonnav mgonnav changed the title [MRG] Update dockerfiles. [MRG] Optimize Dockerfiles Feb 8, 2024
@mgonnav mgonnav merged commit bb89724 into main Feb 8, 2024
@mgonnav mgonnav deleted the update_dockerfiles branch February 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants