Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] feat: Add itemcount in project job overview & item job detail #247

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

joaquingx
Copy link
Contributor

Description

Add item count in job overview and item job detail

Issue

  • Github Issue ID.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@joaquingx joaquingx force-pushed the update-item-count-in-progress-jobs branch from 4f68543 to 4d9b21b Compare October 27, 2024 18:58
@joaquingx
Copy link
Contributor Author

Job Detail page adds item count:
Screenshot 2024-10-27 at 14 04 18

Running jobs in project-job overview now displays the item count:
Screenshot 2024-10-27 at 14 13 54

@joaquingx joaquingx changed the title [WIP] feat: Add itemcount in project job overview & item job detail [MRG] feat: Add itemcount in project job overview & item job detail Oct 27, 2024
@joaquingx joaquingx requested a review from mgonnav October 28, 2024 14:41
Copy link
Contributor

@mgonnav mgonnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaquingx joaquingx merged commit 52bf742 into main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants